Skip to content

Fixed issue #3692 #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from
Open

Fixed issue #3692 #4214

wants to merge 4 commits into from

Conversation

edgeinfinity1
Copy link

@edgeinfinity1 edgeinfinity1 commented May 16, 2025

Fixes #0000

Changes proposed in this pull request:
Fixing an issue causing users unable to rename their posts, which has been confirmed at #3692

Reviewers should focus on:
This is a rather brutal fix, since I'm not too into flarum. Please consider rewriting this in an elegant way.
At least I have confirmed it working on my own deployment at https://forum.monika.love

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@edgeinfinity1 edgeinfinity1 requested a review from a team as a code owner May 16, 2025 10:41
@edgeinfinity1
Copy link
Author

  • Fixed another issue where users cannot delete their own threads while tags enabled. It's the same cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant